-
Mugdha Lakhani authored
This change gets rid of the EditText we were using in InstrumentationTestActivity for weblayer instrumentation tests and replaces it with a UrlBarView returned by UrlBarViewController. All relevant methods have been updated, and a small UrlBarControllerTest added to verify expected behavior. This was previously reviewed and submitted here: https://chromium-review.googlesource.com/c/chromium/src/+/2270442 Geolocation tests were failing on Android L after this change: https://luci-logdog.appspot.com/logs/chromium/android/swarming/logcats/4d4937bf36d05911/+/logcat_logcat_org.chromium.weblayer.test.GeolocationTest.testGeolocation_denyFromPrompt_20200708T215038-UTC_05fcae3f0ae58958 but making them load a static HTML page fixes that. Bug: None Test: ./out/<build_dir>/bin/run_weblayer_instrumentation_test_apk Change-Id: Ia455e56c1424af714659b1b32b8af6a7a6dafa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289976Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#787658}
11b0509e