GitLab

*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not
*** revert this CL. Instead, please disable the offending test(s) and
*** add them to the crbug.com/1053725 section of TestExpectations. I
*** will then take care of them as I fix up the remainder of these
*** tests. Feel free to cc me if you create a bug. Thanks.

This CL enables the FormControlsRefresh flag by default on all Desktop
platforms. The launch bug is crbug.com/1051552.

Because many layout tests use form controls, including tests that are
not directly testing form controls, this CL requires many tests
to be rebaselined. The bug at [1] tracks the effort to re-baseline all
of these tests and remove these new lines from TestExpectations. This
will be done in pieces, to reduce the code review burden. The bug at
[2] tracks cleaning up some of these tests eventually, as there are
new tests (see [3]) that directly test the appearance of the new form
controls, and those likely supersede many rebaselines in this CL.
However, I would like to get this landed first, as it might require
several Revert/Reland cycles to get landed for good, and then I can
come back and do the cleanup.

[1] https://crbug.com/1053725
[2] https://crbug.com/1034611
[3] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/virtual/controls-refresh/

Bug: 1012108, 1053725, 1034611, 1051552
Change-Id: I2d6da06c21567506cf1fc601b90c686c74310376
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063530
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743185}