• Ana Salazar's avatar
    Cros: Reland "Add metrics for transitions in the hotseat" · 11f4508e
    Ana Salazar authored
    Report animation smoothness for the transition into the hotseat in the
    HomeLauncher.
    
    The original change caused use-of-uninitialized-value flaky tests. These
    were caused because the HotseatTransitionAnimator could outlive the
    ShelfWidget in some tests.
    This is a possible fix for the issue by avoiding the destruction of
    |hotseat_transition_animator_| until the Shelf Widget is destroyed, thus
    destroying the animator itself. Shelf Widget destruction occurs usually
    after Shutdown().
    
    Original CL: http://crrev.com/c/1917941
    
    Bug: 1022178, 1022177, 1028255, 1030222
    Change-Id: Ibf2030df7408704e8aa96ca863bcd55ba333174f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954355Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Ana Salazar <anasalazar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#722641}
    11f4508e
shelf_widget.cc 28.7 KB