• Patrick Brosset's avatar
    CDP: Make colors in Page.screencast API accurate · 123ef888
    Patrick Brosset authored
    When capturing frames using the Page.screencast CDP API, the colors are
    a little off.
    It's hard to see with the naked eye, but using a color picker, you can
    see a difference between colors in those frames and colors in similar
    images taken with, e.g., the snip tool on windows.
    
    The reason for this is that the DevTools Video Consumer used by CDP
    does not specify any pixel format or color space when creating its
    underlying FrameSinkVideoConsumer, and therefore the default values are
    used: PIXEL_FORMAT_I420, COLOR_SPACE_HD_REC709
    
    With this fix, we make it possible for the Page.screencast API to
    specify the ARGB pixel format and REC709 color space, and this seems to
    produce images with accurate colors.
    
    Bug: 1141314
    Change-Id: If06f5419c1feaebb3134a5d422769d8123f5518b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593354
    Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
    Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
    Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#838137}
    123ef888
paint_canvas_video_renderer.cc 74.8 KB