GitLab

This reverts commit c8c4c686.

Reason for revert: Causes EventRewriterTest.EventRewriting to fail on Android/Linux CFI starting

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/241

error like

../../ui/events/event.cc:306:10: runtime error: control flow integrity check for type 'ui::LocatedEvent' failed during base-to-derived cast (vtable address 0x0000002689b0)
0x0000002689b0: note: vtable is of type 'ui::(anonymous namespace)::TestEvent'
    #0 0x62afb5 in ui::Event::AsLocatedEvent() const ./../../ui/events/event.cc:306:10
    #1 0x63063a in ui::(anonymous namespace)::IsLocatedEventWithDifferentLocations(ui::Event const&) ./../../ui/events/event_source.cc:19:45
    #2 0x630083 in ui::EventSource::SendEventToSink(ui::Event*) ./../../ui/events/event_source.cc:46:34
    #3 0x4a23e2 in ui::(anonymous namespace)::TestEventRewriteSource::Send(ui::EventType) ./../../ui/events/event_rewriter_unittest.cc:69:5
    #4 0x4a1fe4 in ui::EventRewriterTest_EventRewriting_Test::TestBody() ./../../ui/events/event_rewriter_unittest.cc:188:5


Original change's description:
> chromeos: provide ability to supply event for rewriting
> 
> EventRewriters don't honor the target, and so generally expect the
> root_location and location to be the same. This patch changes EventSource::SendEventToSink()
> to create a new Event if the existing has differing locations (and a target).
> 
> BUG=817112
> TEST=covered by tests
> 
> Change-Id: Iaabe019fed4350610306576a054b7d395def92ff
> Reviewed-on: https://chromium-review.googlesource.com/956925
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542653}

TBR=sadrul@chromium.org,sky@chromium.org

Change-Id: I5ee070c74eba97a446c1a8e71e12f64b90b27401
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 817112
Reviewed-on: https://chromium-review.googlesource.com/958806Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542705}