• Hans Wennborg's avatar
    Reland "[base] Move the CHECK and CHECK_op macros to more light-weight headers" · 12aea3e7
    Hans Wennborg authored
    This is a reland of c195e902
    with a higher token limit in check_op.cc to accommodate release component
    dcheck_always_on=true builds on Linux (see crbug.com/1069971).
    
    It also addresses some post-commit comments on the original CL.
    
    Original change's description:
    > [base] Move the CHECK and CHECK_op macros to more light-weight headers
    >
    > This provides cheaper (in terms of compile time) alternatives for code
    > that just wants to do a few simple CHECKs without pulling in the full
    > weight of logging.h. On Linux, the preprocessed size of check.h and
    > check_op.h are 2% and 62% of logging.h, respectively.
    >
    > Splitting the CHECK and CHECK_op macros out to separate files also
    > reduces the complexity of logging.h which has become very complicated.
    >
    > As a bonus, the new implementation is leaner, causing a 3% local
    > compile-time reduction for the chrome target on Linux even though no
    > includes have been changed yet.
    >
    > Bug: 1031540
    > Change-Id: If7aca321f077110bea0907e487d2e8d29a8c50fd
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128112
    > Commit-Queue: Nico Weber <thakis@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#758287}
    
    Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng
    Bug: 1031540
    Change-Id: Ie524997796b90bea593c1a5f04be5ae0c89f8954
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144180
    Commit-Queue: Hans Wennborg <hans@chromium.org>
    Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#758850}
    12aea3e7
fuchsia_logging.h 2.04 KB