• Sammie Quon's avatar
    Revert "Fix flakiness in ChromeLabsButtonTest.ShowAndHideChromeLabsBubbleOnPress" · 12c756d2
    Sammie Quon authored
    This reverts commit 9cc64477.
    
    Reason for revert: Breaks ChromeOS builder. See https://crbug.com/1165349.
    
    Original change's description:
    > Fix flakiness in ChromeLabsButtonTest.ShowAndHideChromeLabsBubbleOnPress
    >
    > This test is very flaky, I believe because it relies on global state,
    > instead of explicitly setting up the LabInfo used to populate the labs
    > button. For example, if there were no current labs in SetUpLabs, the
    > test would fail. So this CL explicitly sets up the LabInfo for the labs
    > button. It's a bit messy that it requires a change to the production
    > code, but I didn't see any other way of plumbing that information
    > through to the model.
    >
    > Bug: 956719
    > Change-Id: I8078c211e37fc1eeff50a44043eca760cdc4850a
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618656
    > Reviewed-by: Collin Baker <collinbaker@chromium.org>
    > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#842150}
    
    TBR=davidbienvenu@chromium.org,collinbaker@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    Change-Id: I5cd05c29bb299b97fe8b491d865a9925c642a5f5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 956719
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622519Reviewed-by: default avatarSammie Quon <sammiequon@chromium.org>
    Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#842174}
    12c756d2
chrome_labs_button.cc 1.16 KB