• Victor Costan's avatar
    WebSQL: Push state to functions in DatabaseQuotaClientTest. · 130d0b04
    Victor Costan authored
    The test has a few sync wrappers for QuotaClient's async methods. The
    wrappers store the async method results as test fixture members. This
    scope is unnecessarily large, which is an unnecessary mental burden on
    folks who need to understand the test.
    
    This CL stores each async method result as a local variable in the
    method's sync wrapper and removes the member variables.
    DeleteOriginData() is also changed to pass through the async result.
    This will produce more informative messages if the tests fail.
    
    Change-Id: Ia5afba6a532593a610f52beba13efe376dbf46d6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250709
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Auto-Submit: Victor Costan <pwnall@chromium.org>
    Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#779672}
    130d0b04
database_quota_client_unittest.cc 9.31 KB