• Rakina Zata Amni's avatar
    Reland "Copy attributes of old DocumentLoader on javascript: URL & XSLT commits" · 135cd032
    Rakina Zata Amni authored
    This is a reland of 55f04b52
    
    Original change's description:
    > Copy attributes of old DocumentLoader on javascript: URL & XSLT commits
    >
    > When javascript: URL evaluates into a string, or XSLT document change
    > happens, we will commit a new document but won't notify the browser of
    > the change of documents, as no URL/origin change happens, essentially
    > treating it as just a content update within the previously committed
    > document.
    >
    > However, we actually create a new DocumentLoader and Document for the
    > commit, and not all attributes of the old document are actually carried
    > over to the new document. This CL copies most attributes from the
    > previous document through DocumentLoader::CreateParamsToClone(), to
    > ensure future navigations within the new document won't result in
    > confusion in the browser. Some examples of things that are now copied to
    > the new document: HistoryItem, http_method, http_status_code,
    > devtools_navigation_token (so XSLT document transformations show up
    > on devtools), etc.
    >
    > Bug: 1151954, 1048106
    > Change-Id: Iefd620c7c3896f2f1ae2fdcc60404361363124eb
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589206
    > Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    > Reviewed-by: Charlie Reis <creis@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Nate Chapin <japhet@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#843047}
    
    Bug: 1151954
    Bug: 1048106
    Change-Id: I045cd84d088999cb903c0899ebc40cb72219ab3d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628267
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#843355}
    135cd032
web_document_loader.h 6.8 KB