• dschuff's avatar
    Do not use extern template declarations for RectBase etc for NaCl builds · 139fb7ad
    dschuff authored
    The GPU command buffer client uses Rect/RectF from gfx.
    RectBase and friends have an extern template declaration which means that
    instead of inlining the x(), y(), width() and height() methods (e.g. where they
    are used in the header and in gles2_implementation.cc), an external
    reference is generated instead. Unlike in Chromium, the NaCl IRT build does
    not build/link with the gfx/geometry implementation, which means that
    these references never get defined.
    
    So do not use the extern template declarations for NaCl.
    
    R=bbudge@chromium.org (GPU untrusted build), danakj@chromium.org (graphics primitives OWNERS)
    
    TEST= NaCl IRT build with no optimization
    BUG= https://code.google.com/p/chromium/issues/detail?id=388035
    
    Review URL: https://codereview.chromium.org/503953002
    
    Cr-Commit-Position: refs/heads/master@{#291829}
    139fb7ad
rect.h 4.78 KB