GitLab

Previously, stepping backwards into keyword mode was not supported. This
meant that we were always on the "correct" suggestion before trying to
enter keyword mode. This crash happens when we try to enter keyword mode
before updating the selected line, so there would be no keyword
associated with the selected line, causing a segfault or a check to fail.

Changing the accept/clear/setselection order fixed the crash, but
revealed some problems with the KEYWORD_MODE/FOCUSED_BUTTON_KEYWORD
focus distinctions.  These were combined into a singular KEYWORD_MODE
state.

Bug: 1122158
Change-Id: Ib346087e2ebe333c352de6c901ba8662597c849f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389160Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804511}