• Sylvain Defresne's avatar
    Convert //base to not depend on set_sources_assignment_filter() · 13c9a332
    Sylvain Defresne authored
    set_sources_assignment_filter() is considered as a mis-feature
    of gn (as it makes it difficult to reason about the BUILD.gn
    files individually).
    
    Convert BUILD.gn files below //base to instead use conditional
    to include source files only on the platformn where they are
    used.
    
    The conversion was done by using a modified version of gn that
    display all files filtered by set_sources_assignment_filter()
    and updating the BUILD.gn files manually to explicitly add the
    source files only on the platform that used them.
    
    Bug: 1018739
    Change-Id: I236542d7b8e2b5cba5b633b37791d1f1dbbe8d2a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879458
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#710890}
    13c9a332
BUILD.gn 15.3 KB