• danakj's avatar
    Split web_test_support into browser-side and renderer-side components · 256762a4
    danakj authored
    In order to incrementally split content/shell/renderer/web_test out of
    content_shell_lib, into web_test_renderer, we must split apart
    web_test_support.
    
    content_shell_lib must depend on the browser-side code in
    web_test_support, so we move that to web_test_support_browser. Then
    the dependency on web_test_support_renderer needs only be in
    the web_test_renderer target.
    
    Without this change, any dependency on content_shell_lib would also
    include web_test_support_renderer, but not web_test_renderer, which
    causes a build failure due to:
    1) Circular includes between web_test_support_renderer and
       web_test_renderer
    2) So web_test_renderer -> web_test_support_renderer
    3) But web_test_support_renderer -/-> web_test_renderer
    4) This means depending on web_test_support_renderer without going
       through web_test_renderer does not link.
    
    R=avi@chromium.org
    
    Bug: 866140
    Change-Id: If3ae301f44bd2057fb196f39e7947607bb3da60f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134858
    Commit-Queue: danakj <danakj@chromium.org>
    Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#756341}
    256762a4
web_test_support_browser.h 788 Bytes