GitLab

SystemSessionAnalyzerTest.ValidateEvents fails flakily (failing most of
the time) and it is impossible to tell which failure point is being hit.
This change adds recording of extended error codes so that the failure
will be visible so that we can make progress on this old bug.

Some multi-part logical-or statements were broken up to ensure that the
precise failure is found. GetEventInfo was moved to be a member function
so that it has access to the error-setting function.

Test command line is:
components_unittests --gtest_filter=SystemSessionAnalyzerTest.ValidateEvents

Bug: 968440
Change-Id: Ie7b76d6e6607725819244ef22b3a2b1f8ab34d38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136061Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756900}