• Peter Wen's avatar
    Android: Direct deps for chrome/android etc · 14138799
    Peter Wen authored
    Replaced chrome/* with chrome/browser/* in the direct deps allowlist.
    Will deal with chrome/browser/* directory in a later CL.
    
    Added exception for bundle_module headers since although they need to
    depend on their base_module_target's header directly, due to naming, it
    is not as easy to undo the special casing that currently exists for
    these targets (see the rules.gni comment about the "special group").
    
    Almost 1 second faster for turbine headers, and given most of this CL is
    for test targets, probably a good ROI.
    
    Before:
      $ tools/android/build_speed/benchmark.py turbine_headers
      Summary
      gn args: target_os="android" use_goma=true android_fast_local_dev=true
      gn gen: 6.5s
      turbine_headers: 43.6s avg (43.5s, 43.7s)
    After:
      $ tools/android/build_speed/benchmark.py turbine_headers
      Summary
      gn args: target_os="android" use_goma=true android_fast_local_dev=true
      gn gen: 6.5s
      turbine_headers: 42.8s avg (42.8s, 42.8s)
    
    Bug: 1092528
    Change-Id: I088b996e738248bd08650e453d904208128680f6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300802Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Auto-Submit: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#788910}
    14138799
BUILD.gn 6.55 KB