• Samuel Huang's avatar
    Revert "Don't PostTask the RenderWidget::Close() call." · 14360f7e
    Samuel Huang authored
    This reverts commit 8f0dc968.
    
    Reason for revert: Suspected of causing webkit_layout_tests to fail in http/tests/misc/frame-detached-in-animationstart-event.html on WebKit Linux ASAN.
    
    Original change's description:
    > Don't PostTask the RenderWidget::Close() call.
    > 
    > The post task in RenderWidget was in order to keep IPC receipt of
    > destruction of a frame-based RenderWidget (ie a RenderView in the past)
    > from happening while the RenderWidget was already closing due to the
    > renderer-side detaching, but running a nested message loop.
    > 
    > The RenderView destruction now already does a PostTask hop in
    > RenderThreadImpl before starting destruction of the RenderViewImpl
    > and its frame tree and RenderWidgets. A RenderWidget for a frame closes
    > when the frame detaches, and that is built to be consistent even if
    > it occurs inside of unload. The RenderWidget does not need to be kept
    > around after the blink frame and RenderFrame and WebWidget associated
    > with it are all gone.
    > 
    > Popups and pepper RenderWidgets can close during a frame unload without
    > a consistency problem.
    > 
    > R=​dcheng@chromium.org
    > 
    > Bug: 419087
    > Change-Id: Ia5f7ca07395f8a5bd2c60a974a0fb4fb5092d872
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832612
    > Reviewed-by: Avi Drissman <avi@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Commit-Queue: danakj <danakj@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#702868}
    
    TBR=avi@chromium.org,danakj@chromium.org,dcheng@chromium.org
    
    Change-Id: I6edf67e9d004c7f2fb4f3edd36b2a86f4cb5f27a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 419087
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841941Reviewed-by: default avatarSamuel Huang <huangs@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#702926}
    14360f7e
fake_compositor_dependencies.cc 2.82 KB