• Dominic Mazzoni's avatar
    Simplify AXTreeSnapshotterImpl code · 145cb570
    Dominic Mazzoni authored
    This is a simple refactoring that should have no side effects.
    
    The change 'Use EmbeddingTokens as the "backing store" for AXTreeIDs'
    (http://crrev.com/c/2270065) got rid of AXContentTreeUpdate, which was
    previously a more complex version of AXTreeUpdate with some extra
    content-specific fields.
    
    There was a small missed opportunity to refactor here -
    AXTreeSnapshotterImpl was serializing to a AXContentTreeUpdate and
    then converting that to an AXTreeUpdate. Since AXContentTreeUpdate
    no longer exists, the code to populate one struct and then copy it
    to another one is redundant and can be simplified.
    
    This shouldn't result in any change in functionality. AXTreeSnapshotter
    is already covered by tests, primarily in
    snapshot_ax_tree_browsertest.cc
    
    Bug: 1094150, 1161541
    AX-Relnotes: N/A
    Change-Id: If9863ce23cca5538eeab5e0a34350d2f9bfe9e46
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602438Reviewed-by: default avatarMark Schillaci <mschillaci@google.com>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#839193}
    145cb570
render_accessibility_impl.cc 55.9 KB