• Tom McKee's avatar
    Fix gpu process dependency injection plumbing · 1467915a
    Tom McKee authored
    When running the GPU process, we use dependency injection to customize
    its behaviour through the ExternalDependencies struct. VizMainImpl's
    constructor takes an ExternalDependencies parameter and std::moves it to
    a member field. Some of the code, however, continued to reference the
    parameter instead of the field. This lead to the code assuming that some
    dependencies were stubbed out.
    
    This CL updates VizMainImpl's constructor to consistently check the
    member field for the injected values and adds tests to check that some
    injected values end up in use.
    
    Bug: 1040583
    Change-Id: If1c7922f4c7286c2a73afd33572b287ad29f64ce
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992701Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
    Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Tom McKee <tommckee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#733385}
    1467915a
BUILD.gn 19.6 KB