• Mario Sanchez Prada's avatar
    Move RemoteSet<blink::mojom::RendererPreferenceWatcher> to WebViewImpl · 14c0551e
    Mario Sanchez Prada authored
    Now that we have migrated the PageMsg_SetRendererPrefs legacy IPC to
    Mojo and the ownership of blink::RendererPreferences to WebViewImpl,
    we can also move this mojo RemoteSet to WebViewImpl as well, enabling
    us to move even more code from RenderViewImpl into Blink.
    
    Thus, this CL moves |renderer_preferences_watcher| into WebViewImpl by
    defining a new WebView::RegisterRendererPreferenceWatcher() method that
    would receive a CrossVariantMojoRemote as parameter to bind the remote
    in Blink. With that in place WebViewImpl::SetRendererPreferences() does
    no longer rely on RenderViewImpl::DidUpdateRendererPreferences() to
    notify the watchers, getting us one step closer to entirely remove that
    method from WebViewClient and its only implementor i.e. RenderViewImpl.
    
    Bug: 1102442
    Change-Id: If35c5302616e6411198965d35f55f04683a73db4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498503
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
    Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#821236}
    14c0551e
web_view.h 19.6 KB