• Maggie Chen's avatar
    Revert "Update the GPU process termination code in the GPU watchdog." · 14ce0d3e
    Maggie Chen authored
    This reverts commit d2e5eb35.
    
    Reason for revert: <This CL changes the magic signatures in the crash report. Now [GPU hang] becomes [Dump without crash]. Also all signatures that used to show in the hanging functions are now combined into one watchdog function DeliberatelyTerminateToRecoverFromHang(). This is not what it is supposed to be in the crash reports.>
    
    Original change's description:
    > Update the GPU process termination code in the GPU watchdog.
    > 
    > Remove the old code "*((volatile int*)0) = 0x1337" so the crash is
    > separated from other EXCEPTION_ACCESS_VIOLATION buckets for UMA analysis.
    > Use DumpWithoutCrashing() then TerminateProcess instead.
    > 
    > Bug: 949839
    > Change-Id: I29c735aea2d2063043e6a5da80842d62dddf2e34
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940552
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    > Commit-Queue: Maggie Chen <magchen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#723219}
    
    TBR=jam@chromium.org,zmo@chromium.org,wfh@chromium.org,magchen@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 949839
    Change-Id: Ief563313ec634a45f5710ab6ebfa5dacfcf11c72
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962981Reviewed-by: default avatarMaggie Chen <magchen@chromium.org>
    Commit-Queue: Maggie Chen <magchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#724102}
    14ce0d3e
BUILD.gn 6.76 KB