• ager's avatar
    Revert of Revert of Do not call run_webkit_tests.py in android buildbot... · 158f2845
    ager authored
    Revert of Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #1 id:1 of https://codereview.chromium.org/609713002/)
    
    Reason for revert:
    That revert was apparrently a really bad idea. Now all the bots are failing. Reverting the revert and hoping that will bring us back to one failing bot.
    
    Original issue's description:
    > Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #2 id:20001 of https://codereview.chromium.org/603563002/)
    >
    > Reason for revert:
    > Makes the webkit_lint step fail on android bots:
    >
    > @@@BUILD_STEP webkit_lint@@@
    > > /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release
    > Usage: lint-test-expectations [options]
    >
    > lint-test-expectations: error: no such option: --target
    > < /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release
    > ERROR: process exited with code 2
    > @@@STEP_FAILURE@@@
    >
    > Original issue's description:
    > > Do not call run_webkit_tests.py in android buildbot scripts.
    > >
    > > Replace its usage by lint-test-expectations and run-webkit-tests, both
    > > scripts found in third_party/WebKit/Tools/Scripts.
    > >
    > > BUG=338338
    > > TEST=None
    > > R=dpranke@chromium.org,cmp@chromium.org
    > >
    > > Committed: https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10
    > > Cr-Commit-Position: refs/heads/master@{#296883}
    >
    > TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org
    > NOTREECHECKS=true
    > NOTRY=true
    > BUG=338338
    >
    > Committed: https://crrev.com/ce392c3ccf021a094e21ffa3ca3babeb313b4821
    > Cr-Commit-Position: refs/heads/master@{#296892}
    
    TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org
    NOTREECHECKS=true
    NOTRY=true
    BUG=338338
    
    Review URL: https://codereview.chromium.org/598083006
    
    Cr-Commit-Position: refs/heads/master@{#296893}
    158f2845
bb_device_steps.py 25.6 KB