GitLab

This is a reland of a7b569e6

Original change's description:
> Enable -Wunreachable-code in iOS builds (except for internal builds).
> 
> This requires replacing EARL_GREY_TEST_DISABLED with DISABLED_ prefixes
> in cases where the call to EARL_GREY_TEST_DISABLED is unconditional.
> earl_grey/disabled_test_macros.h, which defines EARL_GREY_TEST_DISABLED,
> says:
> 
>     This macro should be used when the configuration for which the
>     test should be disabled can only be determined at runtime.
>     Disabling at compile-time is always preferred.
> 
> So this matches the official guidance, and there are many
> egtests that use DISABLED_ already.
> 
> Bug: 346399
> Change-Id: Ibe51463ec0e6afbd1b3bef629406163118efa64c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125878
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754468}

Bug: 346399
Change-Id: I5c149da6a3a0b9e49caa3e3084015df8c4bb7ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127429
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754535}