• Sammie Quon's avatar
    splitview: Animate phantom windows p1. · 16869bea
    Sammie Quon authored
    spec: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html
    
    The attached spec wants phantom windows to animate out from the "Drag window here"
    indicators. This changes phantom windows from being a separate widget to being part
    of the same widget which controls the splitview text. This will allow the animations
    in the spec to happen.
    
    The phantom windows are now part of those highlights which are part of the splitview
    text. When an item reaches the phantom threshold, the highlight will expand and the
    text will disappear. There is some difficult getting the phantom windows to have
    rounded corners like they should, but the old ones did not either, so I think it is
    ok for now.
    
    The highlights and text layers have their transform and opacity altered rather than
    using SetBounds or SetVisible so it will be easier to animate in a follow up cl.
    
    Manually tested using all orientations and multiple divider positions.
    
    Test: ash_unittests SplitViewWindowSelectorTest.*
    Bug: 808283
    Change-Id: I4b61e5dce394ac05abd4038aee3a07067727f625
    Reviewed-on: https://chromium-review.googlesource.com/898247Reviewed-by: default avatarMitsuru Oshima (In Tokyo) <oshima@chromium.org>
    Reviewed-by: default avatarXiaoqian Dai <xdai@chromium.org>
    Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#537160}
    16869bea
rounded_rect_view.cc 1.26 KB