• Andrew Grieve's avatar
    Reland "build_vars.txt: Changed to build_vars.json" · 169e377d
    Andrew Grieve authored
    This reverts commit 67fc091c.
    
    Reason for reland: Writing both build_vars.json & build_vars.txt
    
    Original change's description:
    > Revert "build_vars.txt: Changed to build_vars.json"
    >
    > This reverts commit 6e002e1f.
    >
    > Reason for revert: Official build failure crbug.com/1114609
    >
    > Original change's description:
    > > build_vars.txt: Changed to build_vars.json
    > >
    > > And moved helper function into gn_helpers.py
    > >
    > > It was only ever in .properties format so that it
    > > could be easily parsed by bash, but we no longer need
    > > that.
    > >
    > > Also fixes default_android_sdk_version to be a string.
    > > -next builds need it to be a string.
    > >
    > > Bug: None
    > > Change-Id: I99541f18510de93dae4c0d68b734638564f74ee2
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340673
    > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
    > > Reviewed-by: Dirk Pranke <dpranke@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#796020}
    >
    > TBR=dpranke@google.com,agrieve@chromium.org,mheikal@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: None
    > Change-Id: Iad8597f6af00c534245fd1a40d1809d952758f47
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344626
    > Reviewed-by: Ben Mason <benmason@chromium.org>
    > Commit-Queue: Ben Mason <benmason@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#796387}
    
    Bug: 1114750
    Change-Id: I1019351a294e54701c093911f67a1fb6b7bd34d0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346965Reviewed-by: default avatarBen Mason <benmason@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#796456}
    169e377d
BUILD.gn 4.06 KB