• Siddhartha's avatar
    Enable extracting unwind table on official builds without channel · 16e808d7
    Siddhartha authored
    The original cl was here:
    https://chromium-review.googlesource.com/c/chromium/src/+/990092
    This CL fixes the following problems with the original CL:
    1. The apk_merger script fails because the unwind tables were only added
       in 32-bit apk. The merger script expects all the files to be same and
       the ones different should be checked.
     1a. The resources.arsc is non-hermetic and ordering is affected by
         adding file to only one apk. As a workaround for crbug/828528,
         add an empty (valid) unwind table file to the 64 bit monochrome
         apk to make the resource.arsc consistent.
     1b. The merger script simply adds all the files in apk which are not
         same. To keep the script simple and functional, the unwind resource
         is renamed to unwind_cfi_32 and unwind_cfi_empty in respective
         builds and the app_merger is updated to specify this file is
         expected to be different and included. This causes an extra file
         (4 byte) in the merged apk.
    
    2. The unwind tables were always generated for "libchrome.so" for all
       chrome apks. The different chrome_apk(s) have different shared
       libraries like libchromefortest, etc.. So, update the unwind asset to
       get unwind table for the right library for each apk. Only adds assets
       to *_public_apk(s).
    
    3. The monochrome_apk_checker was failing because the unwind file
       included was different in chrome_apk and monochrome_apk. This CL adds
       the asset to all apk at the same time and adds exception for this
       file.
    
    BUG=819888
    TBR=dpranke@chromium.org
    
    Change-Id: Ibceeeacc19fa424d519891b8c17e349ee6c2dfd6
    Reviewed-on: https://chromium-review.googlesource.com/991236
    Commit-Queue: Siddhartha S <ssid@chromium.org>
    Reviewed-by: default avatarMaria Khomenko <mariakhomenko@chromium.org>
    Reviewed-by: default avatarBo <boliu@chromium.org>
    Reviewed-by: default avataragrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#547993}
    16e808d7
extract_unwind_tables.py 10.6 KB