• Jesse McKenna's avatar
    Disable stack sampling profiler under App Verifier · 17178955
    Jesse McKenna authored
    The StackSamplingProfiler has been observed to cause crashes when
    running under Application Verifier, a Windows utility used to detect
    subtle programming errors. Samples collected by the
    StackSamplingProfiler while Application Verifier is running are unlikely
    to hold any value, as Application Verifier slows down execution
    significantly.
    
    Because StackSamplingProfiler and Application Verifier are not
    compatible, this change detects whether Application Verifier is running,
    and does not start up StackSamplingProfiler if so.
    
    This is not expected to impact data collection, as Application Verifier
    is used only by a few developers.
    
    Bug: 1004989
    Change-Id: I014b3cee440e99d832ae8d84a03fe70777676a2b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783735
    Commit-Queue: Jesse McKenna <jessemckenna@google.com>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
    Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#700356}
    17178955
stack_sampling_configuration.cc 6.52 KB