GitLab

This reverts commit de77cb76.

Reason for revert: https://crbug.com/842408 should now be fixed.

Original change's description:
> Revert "Reland "win: Link with lld instead of link.exe by default""
> 
> This reverts commit a25e3672.
> 
> Reason for revert: broke Windows tests using ANGLE's GL back-end.
> Breaks the CQ for graphics-related tests, and ANGLE's CQ.
> 
> example builds:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/1063
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20dEQP%20Release%20%28NVIDIA%29/3528
> 
> Original change's description:
> > Reland "win: Link with lld instead of link.exe by default"
> > 
> > The nacl browser_test failures on Win7 that caused the last revert are fixed.
> > There's a known bug about this regressing binary size (crbug.com/838449),
> > but with in-progress patches binary size will soon be 200 kB smaller and
> > these should all be rolled in by branch point, so let's reland this to find
> > more unknown unknowns.
> > 
> > Original change's description:
> > > win: Link with lld instead of MSVC's link.exe by default
> > >
> > > lld is LLVM's linker. It produces PE/COFF and PDB files just like
> > > link.exe, but it's significantly faster and it can also handle LLVM's
> > > internal representation, which will enable us to do link-time
> > > optimization and control-flow integraty checks with Clang.
> > >
> > > While lld is much faster at linking, it doesn't support incremental
> > > links, meaning builds that only touch a few files and re-link a large
> > > executable may become slower.
> > >
> > > This is the first attempt at switching everything over, with the
> > > purpose of gathering data and finding unknown unknowns. It's likely
> > > temporary until something breaks.
> > >
> > > is_win_fastlink is implicitly ignored when using lld, as lld without
> > > fastlink is faster than link.exe with it.
> > >
> > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's
> > > link.exe to make sure that configuration keeps working.
> > >
> > > Bug: 792131
> > 
> > Change-Id: I18aba7a66c54c87092a13745f0ca213171ec25db
> > Reviewed-on: https://chromium-review.googlesource.com/1054521
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Reid Kleckner <rnk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#557987}
> 
> TBR=thakis@chromium.org,rnk@chromium.org
> 
> Change-Id: Ida516adc6708c59407b817c8425c14bd3153d5b8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1056327
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558055}

TBR=thakis@chromium.org,rnk@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ided62bd7fb25d17d7a318539f41c308fb738797e
Reviewed-on: https://chromium-review.googlesource.com/1057767Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558402}