• Dale Curtis's avatar
    Fix broken MediaCodec VP8 drain when using asynchronous API. · 17392d78
    Dale Curtis authored
    We invalidated the callback we give to MediaCodecBridge for asynchronous
    API callbacks during MCVD::Destroy(), so we never get notified when the
    EOS we queued as input completes. Thus leaking VP8 players continuously!
    
    We could change to not invalidating the WeakPtr for the asynchronous
    callback, but since draining is for a KitKat era issue, lets drop the
    drain entirely when using the asynchrous API (N+).
    
    BUG=1006092
    TEST=vp8 instances are no longer leaked.
    R=liberato
    
    Change-Id: I3ea9c6013686000f176891eb8e645a60430adc71
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906116
    Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
    Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#714033}
    17392d78
media_codec_video_decoder.cc 46 KB