-
Yu Han authored
This reverts commit b1ce4a4e. Reason for revert: FormControlsBrowserTest.Input is failing in step "bf_cache_content_browsertests on Android device Nexus 5" on builder "android-bfcache-rel" List of failed builders: Builder: android-bfcache-rel https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel First failing build: https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel/b8858287909548350672 Original change's description: > Reland "[Controls Refresh Android] Fixes input missing border" > > This is a reland of 909901eb > > The revert was due to greater pixels error difference between > Mac 10.12 & 10.15 and the baseline. > > After checking the error rate on failed Mac bots, the fix is > to increase the error_pixels_percentage_limit from 9f to 10.2f in > form_controls_browsertest::FuzzyPixelComparator. > > Original change's description: > > [Controls Refresh Android] Fixes input missing border > > > > Prior to this CL, controls-refresh text input is missing its border. > > > > The fix is to make sure property text_field.has_border is passed to > > native theme. This property is only used by form controls-refresh > > so it has no impact on existing text input. > > > > Bug: 1155397 > > Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495 > > Reviewed-by: Camille Lamy <clamy@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Commit-Queue: Yu Han <yuzhehan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#841106} > > Bug: 1155397, 1164011 > Change-Id: I6f06173f677b45664ff4cb6dedfb9197b8ece95b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618675 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842590} TBR=clamy@chromium.org,masonfreed@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yuzhehan@chromium.org Change-Id: I50b6869b0bb25b37207920ff401fd8a33ba5d85e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155397 Bug: 1164011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625779Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842764}
1815db9e