• Luciano Pacheco's avatar
    Files app: Fix FilesAppEntryTypes test · 1821a613
    Luciano Pacheco authored
    Rename the test FilesAppEntryTypes because the flake was due to the
    dep `:files_app_entry_types_unittest.m` being commented out, which is
    fixed in this CL.
    
    Change js_test_gen_html() build rule to use `invoker.js_module` instead
    of `forward_variables_from()` because when there was multiple files in
    the same build target, it was failing with this error:
    
    ```
    ERROR at //ui/file_manager/base/gn/js_test_gen_html.gni:117:39: Clobbering existing value.
        forward_variables_from(invoker, [ "js_module" ])
                                          ^----------
    The current scope already defines a value "js_module".
    forward_variables_from() won't clobber existing values. If you want to
    merge lists, you'll need to do this explicitly.
    ```
    
    Bug: 1146484
    Change-Id: Ifcf3105ef5f63d6d2e9e2ec9ce8cad7813b4cd38
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525473
    Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: default avatarJeremie Boulic <jboulic@chromium.org>
    Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#825269}
    1821a613
file_manager_jstest.cc 8.55 KB