• Christopher Cameron's avatar
    MacPWAs: Add app shim and browser-side logging to debug app connection · 1871e6a2
    Christopher Cameron authored
    We are getting reports of the browser process rejecting connections
    from app shims from the field. The failures happen after Chrome has
    been open for a while (so reproducing from the console to get logs is
    not an option).
    
    Address this in two ways.
    1. Add more LOG(INFO) calls in the app shim process itself. This is
       needed (and is here to stay) because, if something goes wrong
       connecting to Chrome or loading the Chrome framework, there is no
       other mechanism for getting feedback (no crash reports, etc).
    2. Add four NSLog calls in the browser, for
       - Mach connection received
       - Mojo connection received first message
       - Mojo connection disposition (use or discard), so 2 calls here
       - Mojo connection closed (regardless of disposition)
       These calls are NOT here to stay -- they are for debugging problems
       we are seeing in Chrome 80. They are likely to be moved to an
       internal URL.
    
    Disabling presubmit because this is intentionally adding LOG(INFO)s.
    
    NOPRESUBMIT=True
    
    Bug: 1052131
    Change-Id: Ia6fd1cb21802c97d8b9fed6146db48fdc3463e93
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055994Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#741747}
    1871e6a2
app_shim_controller.mm 18.9 KB