• Dominique Fauteux-Chapleau's avatar
    Revert "Enable -Wunreachable-code in iOS builds (except for internal builds)." · 18926aac
    Dominique Fauteux-Chapleau authored
    This reverts commit a7b569e6.
    
    Reason for revert: Closed the tree
    
    Original change's description:
    > Enable -Wunreachable-code in iOS builds (except for internal builds).
    > 
    > This requires replacing EARL_GREY_TEST_DISABLED with DISABLED_ prefixes
    > in cases where the call to EARL_GREY_TEST_DISABLED is unconditional.
    > earl_grey/disabled_test_macros.h, which defines EARL_GREY_TEST_DISABLED,
    > says:
    > 
    >     This macro should be used when the configuration for which the
    >     test should be disabled can only be determined at runtime.
    >     Disabling at compile-time is always preferred.
    > 
    > So this matches the official guidance, and there are many
    > egtests that use DISABLED_ already.
    > 
    > Bug: 346399
    > Change-Id: Ibe51463ec0e6afbd1b3bef629406163118efa64c
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125878
    > Auto-Submit: Nico Weber <thakis@chromium.org>
    > Commit-Queue: Nico Weber <thakis@chromium.org>
    > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#754468}
    
    TBR=thakis@chromium.org,sdefresne@chromium.org
    
    Change-Id: Ib0ccce331d5063a2f22ed9c25ebdf40bf3bd19d4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 346399
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127487Reviewed-by: default avatarDominique Fauteux-Chapleau <domfc@chromium.org>
    Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#754470}
    18926aac
BUILD.gn 83.4 KB