• Dale Curtis's avatar
    Don't allow MultiBuffer size increases until kReadyStateHaveEnough. · 18ad391b
    Dale Curtis authored
    Since we started allowing play() to occur before the future data state,
    we can now run into cases where MultiBuffer ends up increasing its
    buffer sizes before renderer initialization starts. It will not satisfy
    reads until the new larger buffer sizes are fulfilled, which causes
    playback startup delays.
    
    There's no reason to do this since we can just increase the size after
    playback starts without penalty. So prevent size increases before
    kReadyStateHaveEnough and invoke them only after reaching that state.
    
    BUG=965684
    TEST=new unittest.
    R=sandersd
    
    Change-Id: I0a7a37528f8c814731a34b6bcc4a6c9a3f9ca5d4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637527
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
    Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#664952}
    18ad391b
multibuffer_data_source.cc 24.2 KB