• Shivani Sharma's avatar
    History intervention: Reset skippable bit if user gesture after pushState · 19487703
    Shivani Sharma authored
    If a navigation entry was marked as skippable because it added an entry
    using pushState, then a user gesture on the page should reset the skippable
    bit. If the pushState was done after the user gesture, then the entry would
    not have been marked as skippable to begin with. This change will make the
    behavior independent of the ordering between user gesture and pushState.
    
    content_browsertests --gtest_filter=
    NavigationControllerHistoryInterventionBrowserTest.
    OnUserGestureResetSameDocumentEntriesSkipFlag
    content_browsertests --gtest_filter=
    NavigationControllerHistoryInterventionBrowserTest.
    OnUserGestureDoNotResetDifferentDocumentEntrySkipFlag
    
    Test: 
    Bug: 937423
    Change-Id: Ie1e55815163ca84950ed7e04fbfa55c06f86c2cf
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499834
    Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
    Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#638641}
    19487703
navigation_controller_impl.h 23.4 KB