• Henrik Boström's avatar
    Delete WebRtcRtpBrowserTest. · 199c6b4e
    Henrik Boström authored
    Tests that can be expressed as LayoutTests (preferreably Web Platform
    Tests) rather than browser tests should. Browser tests are slow to run
    and a maintenance burden.
    
    The WebRtcRtpBrowserTests are mainly testing behaviors of adding and
    removing tracks/streams and asserting that the expected outcomes.
    
    - The essentials of these tests are already covered in
      external/wpt/webrtc/ which we are actively maintaining and updating in
      preparation for Unified Plan and RTCRtpTransceiver support. Almost all
      of it is overlapping.
    - The WebRtcRtpBrowserTests were not written to test behaviors, but
      functions. Each test is asserting a lot of unrelated behaviors.
    - When running with Unified Plan/RTCRtpTransceiver (WIP CL:
      https://chromium-review.googlesource.com/c/chromium/src/+/1025771)
      these tests start failing. I started updating these tests but the
      failures were due to Plan B assumptions (problems in the tests, not in
      the implementation).
    - Debugging this part of the code is slow and cumbersome.
    - I won't miss any of these tests.
    
    Conclusion: Nuke it.
    
    Bug: 773472, 777617
    Change-Id: I099992f1783914d4fb1d5c2d952ff977ec4cc513
    Reviewed-on: https://chromium-review.googlesource.com/1100891Reviewed-by: default avatarPatrik Höglund <phoglund@chromium.org>
    Commit-Queue: Henrik Boström <hbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#567283}
    199c6b4e
webrtc_jsep01_test.html 1.21 KB