• Nico Weber's avatar
    win: Don't use rc.exe's built-in preprocessor. · 19cb4031
    Nico Weber authored
    Microsoft rc.exe has its built-in preprocessor that has a limit of 32
    characters for macro names.
    
    We already use clang-cl's preprocessor for our own rc that we use in cross
    builds. That works well, so feed the output from that into Microsoft
    rc.exe too.
    
    This allows removing some workarounds for BUILDFLAG() use in .rc files and
    shouldn't change behavior.
    
    Bug: 961769
    Change-Id: I21ea2e62323a27c61f8c79c267814ed2f522eded
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860097
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Commit-Queue: Robert Sesek <rsesek@chromium.org>
    Auto-Submit: Nico Weber <thakis@chromium.org>
    Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#705630}
    19cb4031
chrome_dll.rc 10.6 KB