• Darren Shen's avatar
    [VK] Use semantically-correct bounds when querying keyboard bounds. · 1a18c3f0
    Darren Shen authored
    There are several places where we query the keyboard bounds by
    grabbing the keyboard container window and calling |bounds|. However,
    it's unclear whether they mean the bounds relative to parent or bounds
    relative to the screen, since both are currently the same for the
    keyboard container.
    
    This patch changes several callers to use |GetBoundsInScreen| since
    they actually want the screen bounds. Note we don't change any behaviour
    since currently keyboard container |bounds| == |GetBoundsInScreen|, but
    this will change in future when we get rid of keyboard container.
    
    Bug: 849980
    Change-Id: I7211073a7697f168824c127319dfc40e6888195a
    Reviewed-on: https://chromium-review.googlesource.com/1098417
    Commit-Queue: James Cook <jamescook@chromium.org>
    Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#567253}
    1a18c3f0
magnification_controller.cc 34.4 KB