• Etienne Pierre-Doray's avatar
    Revert "[TaskScheduler]: Migrate off of ScopedAllowWait in /android_webview" · 1ab594e7
    Etienne Pierre-Doray authored
    This reverts commit bcc4146d.
    
    Reason for revert: android.webkit.cts.WebViewStartupTest#testCookieManagerBlockingUiThread is consistently failing.
    
    Bug: 905025
    
    Original change's description:
    > [TaskScheduler]: Migrate off of ScopedAllowWait in /android_webview
    > 
    > base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
    > explicit counterpart.
    > 
    > It should have been replaced by :
    >  * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
    >  * base::ScopedAllowBaseSyncPrimitives in non-test files
    >  * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
    >    that don't allow blocking
    > The last one is strongly frowned upon but this CL aims to document existing
    > behavior rather than address it. Owners are encouraged to follow-up by fixing
    > unnecessary waits and more particularly unnecessary waits
    > outside-blocking-scope.
    > 
    > Note: The non-for-testing versions require friend'ing in thread_restrictions.h
    > but care was taken to add these friends ahead of git cl split (since it wasn't
    > possible to do a line-by-line associated CL split).
    > Refer to the top-level CL if necessary :
    > https://chromium-review.googlesource.com/c/chromium/src/+/1288533
    > 
    > Please CQ if LGTY!
    > 
    > This CL was uploaded by git cl split.
    > 
    > R=​torne@chromium.org
    > 
    > Bug: 766678
    > Change-Id: I30e57cb0d9a0b1a449a4227561e97ea330ff6a12
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325195
    > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > Reviewed-by: Richard Coles <torne@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607674}
    
    TBR=gab@chromium.org,torne@chromium.org,etiennep@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 766678
    Change-Id: If1ee0994f4387786662d7814617b297939b4dffb
    Reviewed-on: https://chromium-review.googlesource.com/c/1337637Reviewed-by: default avatarEtienne Pierre-Doray <etiennep@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608392}
    1ab594e7
aw_form_database_service.cc 3.64 KB