• Junyi Xiao's avatar
    Revert "WebApps: Remove install pwa icon from toolbar when page crashed" · 1acd6cea
    Junyi Xiao authored
    This reverts commit 402e8644.
    
    Reason for revert: This changes caused an new bug and a perf regression on startup. 
    
    Back it out for now, and will try to fix the original bug appropriately later.
    
    Original change's description:
    > WebApps: Remove install pwa icon from toolbar when page crashed
    > 
    > This change 1. hides the install pwa page action icon in the toolbar
    > 2. grayed out "create shortcut" and "Install {pwaName}" menu items
    > when page crashed.
    > 
    > Bug: 1057526, 1059934, 1059172
    > 
    > Change-Id: I63d5e3607e9aff71ab2bd799d792f025b142ec42
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078771
    > Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
    > Reviewed-by: Peter Kasting <pkasting@chromium.org>
    > Reviewed-by: Alan Cutter <alancutter@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#746305}
    
    TBR=pkasting@chromium.org,alancutter@chromium.org,mjackson@microsoft.com,lomitch@microsoft.com,juxiao@microsoft.com,sunggch@microsoft.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1057526
    Change-Id: I69d4e20f4b50c12a56abade08eaf0843c3764d08
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097540
    Commit-Queue: Lorne Mitchell <lomitch@microsoft.com>
    Reviewed-by: default avatarLorne Mitchell <lomitch@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#749294}
    1acd6cea
web_app_browsertest.cc 31.5 KB