• Danyao Wang's avatar
    Revert "[Nav Experiment] Call LoadIfNecessary() in CWVWebView session restore." · 1ae59532
    Danyao Wang authored
    This reverts commit b21bf2bb.
    
    Reason for revert: broke the build: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8923328721517960816/+/steps/compile/0/stdout
    
    Original change's description:
    > [Nav Experiment] Call LoadIfNecessary() in CWVWebView session restore.
    > 
    > The web view load scheduled by WKBasedNavigationManager::Restore() is
    > deferred when used in CWVWebView's |resetWebStateWithSessionStorage|
    > because the |_containerView| is not created until later. This CL calls
    > LoadIfNecessary() explicitly after the view is created to trigger the
    > session restoration.
    > 
    > This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    > enabled. A better approach would be to turn this test into a
    > programmatic test so both navigation managers implementations are
    > tested, but web::features symbols are not exposed in ios/web_view.
    > 
    > Bug: 862714
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
    > Change-Id: I21e694e3fef6a833f1cce04ff9cebd3784349111
    > Reviewed-on: https://chromium-review.googlesource.com/c/1135435
    > Commit-Queue: Danyao Wang <danyao@chromium.org>
    > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    > Reviewed-by: Justin Cohen <justincohen@chromium.org>
    > Auto-Submit: Danyao Wang <danyao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#626170}
    
    TBR=justincohen@chromium.org,eugenebut@chromium.org,jbudorick@chromium.org,danyao@chromium.org,ichikawa@chromium.org
    
    Change-Id: Ie5346cd1e76b6e7510f589e2cb36602ed7cc0fbd
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/c/1436172Reviewed-by: default avatarDanyao Wang <danyao@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#626181}
    1ae59532
cwv_web_view.mm 24.8 KB