• arthursonzogni's avatar
    Force error page to be classified as cross-document. · 1b0a991d
    arthursonzogni authored
    Bug https://crbug.com/1018385 is caused by navigation initially
    classified as "same-document" committing error pages.
    
    During the commit phase of the navigation, the NavigationRequest is
    transfered in one of these RenderFrameHostImpl's bucket:
     - same_document_navigation_request_
     - navigation_requests_
    
    A navigation classified as "same-document" ends up in the bucket
    incompatible with error pages.
    DidCommitPerNavigationMojoInterfaceNavigation expects to find the
    navigation is the other bucket.
    
    Add several regressions tests, including WPT tests.
    
    Bug: 1018385
    Change-Id: I3d92af1dd487f7b60a3e50a792716a07b074e5eb
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886339
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#712541}
    1b0a991d
navigation_browsertest.cc 128 KB