• Yuta Kitamura's avatar
    Revert "Add supports for Objective-C blocks to base::Bind*" · 1b1b5aec
    Yuta Kitamura authored
    This reverts commit 3a2babeb.
    
    Reason for revert: Suspected cause of ASAN failure (bug 845687)
    and Mac-only flakiness (bug 845760, but 845759, bug 845690).
    
    Original change's description:
    > Add supports for Objective-C blocks to base::Bind*
    > 
    > Add template specifialization allowing to use base::Bind* with
    > Objective-C block. To avoid breaking ODR, it is necessary to
    > use base::WrapBlock() when ARC support is disabled, but when
    > it is enabled, the block can be directly bound by base::Bind*.
    > 
    > This also allow to use base::BindOnce() with blocks and thus
    > pass them  move-only objects, allowing the following:
    > 
    >   __weak Foo* weakSelf = self;
    >   std::unique_ptr<Bar> bar = ...;
    >   base::OnceClosure closure = base::BindOnce(
    >       ^(std::unique_ptr<Bar> bar) {
    >           [weakSelf adoptBar:std::move(bar)];
    >       }, std::move(bar));
    > 
    > The base::BindBlock and base::BindBlockArc templates are kept for
    > compatibility but are now just wrapper for base::BindRepeating.
    > 
    > Bug: 701275
    > Change-Id: I6e5d5309bcae768b2d1e8425b27ca295098e30b1
    > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    > Reviewed-on: https://chromium-review.googlesource.com/977912
    > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    > Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#560634}
    
    TBR=thakis@chromium.org,sdefresne@chromium.org,tzik@chromium.org
    
    Change-Id: Id72a1806176f830a1887243fcd2795a927e7d638
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 701275
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Reviewed-on: https://chromium-review.googlesource.com/1068588Reviewed-by: default avatarYuta Kitamura <yutak@chromium.org>
    Commit-Queue: Yuta Kitamura <yutak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#560951}
    1b1b5aec
bind.h 17.6 KB