GitLab

This reverts commit 8380640d.

> > fuchsia: Avoid unnecessary references to WindowEventFilter
> >
> > The link error I'm trying to avoid is this:
> >
> > [122->5/127 ~1] SOLINK ./libviews.so
> > FAILED: libviews.so libviews.so.TOC lib.unstripped/libviews.so
> > python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --strip=../../third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libviews.so" --tocfile="./libviews.so.TOC" --output="./libviews.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,-z,max-page-size=4096 -Wl,--icf=all -Wl,--color-diagnostics --target=aarch64-fuchsia -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/arch/arm64/sysroot -L../../third_party/fuchsia-sdk/sdk/arch/arm64/lib -o "./lib.unstripped/libviews.so" -Wl,-soname="libviews.so" @"./libviews.so.rsp"
> > ld.lld: error: undefined symbol: views::WindowEventFilter::WindowEventFilter(views::DesktopWindowTreeHost*)
> > >>> referenced by memory:3118 (../../buildtools/third_party/libc++/trunk/include/memory:3118)
> > >>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
> >
> > ld.lld: error: undefined symbol: views::WindowEventFilter::SetWmMoveResizeHandler(ui::WmMoveResizeHandler*)
> > >>> referenced by desktop_window_tree_host_platform.cc:106 (../../ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc:106)
> > >>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
> > clang: error: ld.lld command failed with exit code 1 (use -v to see invocation)
> >
> > I'm not sure what the correct approach is; DesktopWindowTreeHostPlatform
> > depends on WindowEventFilter which uses LinuxUI.
> >
> > Since there's no available non-client area on Fuchsia currently, not
> > doing this seems correct for the time being. Or does Fuchsia really need
> > its own DesktopWindowTreeHostFuchsia implementation?
> >
> > Bug: 808287
> > Change-Id: I2af683415ea00147607eb4236540d8d3e8643603
> > Reviewed-on: https://chromium-review.googlesource.com/c/1298554
> > Commit-Queue: Scott Graham <scottmg@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602860}
>
> TBR=sky@chromium.org,scottmg@chromium.org,thomasanderson@chromium.org
>
> Change-Id: I00a7631118f58db9413c391416079c4f94a974ae
> Bug: 808287
> Reviewed-on: https://chromium-review.googlesource.com/c/1300101
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602887}

TBR=sky@chromium.org,scottmg@chromium.org,thomasanderson@chromium.org

Change-Id: I3302a0dec267ebec369d53ec8906c1c31cd12ba0
Bug: 808287
Reviewed-on: https://chromium-review.googlesource.com/c/1300110
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602975}