GitLab

PS1 is the original reland, PS2 is the re-reland, including:

 1. A fix for the original problem in structured_metrics_provider.cc
 2. A test covering that case into s_m_p_unittest.cc
 3. A deleted include that's no longer necessary after another CL.

This is a reland of 4b79ed37

Original change's description:
> Reland "[Structured metrics] Add metric collection and upload logic."
>
> This is a reland of 2fe77415
>
> Original change's description:
> > [Structured metrics] Add metric collection and upload logic.
> >
> > This is the final CL for the core of the structured metrics system. It
> > ties together the KeyData class (for managing keys and computing hashes)
> > with the metrics provider, and implements logic to:
> >
> >  1. Hash and store incoming structured metrics events.
> >  2. Provide stored metrics events for upload.
> >
> > It also adds integration tests for the system, checking that an event
> > created through the public API is correctly prepared for upload.
> >
> > Other misc changes:
> >
> >  - Some minor refactoring of event_base.{h,cc} and equivalent changes
> >    to events_template.py, to fix some bad style.
> >  - Added a missing RemoveObserver call to the metrics provider dtor.
> >
> > Bug: 1016655
> > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386
> > Commit-Queue: Tony Yeoman <tby@chromium.org>
> > Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#735748}
>
> Bug: 1016655
> Change-Id: I83e69de7a9b865d35036b714f068cfda3c423b76
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026913
> Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> Commit-Queue: Tony Yeoman <tby@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736590}

Bug: 1016655
Change-Id: I54b06543c5ac3075cd1256d651d3232e6739c7a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034387
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738390}