• Will Harris's avatar
    Disable CIG under ASAN. · 1b9b415c
    Will Harris authored
    ASAN has not yet fully initialized by the time the CIG intercepts
    execute. Most of the code works fine but the call to
    std::unique_ptr ends up hitting an uninitialized instrumentation
    and crashing.
    
    Various options were considered including:
    
     * Add all of the std::unique_ptr calls used in the interception
       code to the exclusion list.
     * Implement our own smart pointers in the interception.
     * Just use stack allocations and/or dumb pointers in interception.
    
    It seemed, upon reflection, the best use of engineering resources
    to just disable CIG on ASAN builds.
    
    BUG=995986
    
    Change-Id: I5078a21c70864d7e14a8196ec05bb217b3251f41
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763095Reviewed-by: default avatarJames Forshaw <forshaw@chromium.org>
    Commit-Queue: Will Harris <wfh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#689208}
    1b9b415c
signed_interception.cc 2.89 KB