• Brian White's avatar
    Have histogram-functions take native char* names. · 1be08774
    Brian White authored
    Without this, the compiler emits ctor/dtor code to convert constant
    strings to std::string making the call about 100x larger in size and
    almost 2x the size of a caching macro instantiation.
    
    According to the Android binary-size try-bot, saves about 4K...
    
    Specifics:
    -4,096 bytes main lib size
    -4,738 bytes normalized apk size
    InstallSize:
    -4,122 bytes APK size
    -4,122 bytes Estimated installed size (Android Go)
    -4,122 bytes Estimated installed size
    InstallBreakdown (-4,066 bytes):
    +28 bytes unwind_cfi (dev and canary only) size
    -4,096 bytes Native code size
    +2 bytes Package metadata size
    
    
    Bug: 944842
    Change-Id: I4b9bdff28acfa7b0e5146de74fd922a5c8245b4e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630968Reviewed-by: default avatarNik Bhagat <nikunjb@chromium.org>
    Commit-Queue: Brian White <bcwhite@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#663838}
    1be08774
histogram_functions.cc 8.35 KB