• nick's avatar
    PlzNavigate: don't reuse current_frame_host() for error pages · 1c2f3f0b
    nick authored
    if the navigation is browser-initiated. The "stay in current
    process to prevent privilege escalation" strategy is only valid
    when the navigation was initiated by that process.
    
    (As an aside, it is worth pointing out that current_frame_host is
    not necessarily the initiator process.)
    
    This change prevents a CheckWebUIRendererDoesNotDisplayNormalURL browser
    crash in the scenario where the current page is chrome://settings, and
    the user types in an URL that happens to be blocked by a
    NavigationThrottle. This scenario starts being possible once
    ExtensionNavigationThrottle starts doing more aggressive blocking of
    top-level navigations.
    
    BUG=661324
    TEST=ToolbarModelTest.ShouldDisplayURL
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
    
    Review-Url: https://codereview.chromium.org/2884123002
    Cr-Commit-Position: refs/heads/master@{#472303}
    1c2f3f0b
navigation_request.cc 36.7 KB