• Aleks Totic's avatar
    Revert "Reland "Desktop PWAs: Unit test helper method InstallWebApp"" · 1c38d210
    Aleks Totic authored
    This reverts commit d3872f63.
    
    Reason for revert:  Reland of revert for MSAN failure, crbug.com/1096592
    
    Original change's description:
    > Reland "Desktop PWAs: Unit test helper method InstallWebApp"
    > 
    > This reverts commit 359f3700.
    > 
    > Reason for revert: Broke build due to dependent CLs existing.
    > 
    > Original change's description:
    > > Revert "Desktop PWAs: Unit test helper method InstallWebApp"
    > >
    > > This reverts commit 7db3de6c.
    > >
    > > Reason for revert: MSAN failure, crbug.com/1096592
    > >
    > > Original change's description:
    > > > Desktop PWAs: Unit test helper method InstallWebApp
    > > >
    > > > Extract unit test helper method InstallWebApp from unit tests to
    > > > web_app_unittest_util.h/cc and retire duplicate implementations.
    > > >
    > > > Drive-by: retire unused method FinalizeInstall
    > > > in web_app_install_manager_unittest.cc
    > > >
    > > > TBR=agawronska@chromium.org
    > > >
    > > > Change-Id: I5f7574ef89dfe1543727c2376d8002e2e6fce822
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247991
    > > > Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
    > > > Reviewed-by: Alexey Baskakov <loyso@chromium.org>
    > > > Reviewed-by: Dominick Ng <dominickn@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#779607}
    > >
    > > TBR=ericwilligers@chromium.org,loyso@chromium.org,dominickn@chromium.org
    > >
    > > Change-Id: I1b50d2ed80fbe29b9e742c7a533d3a0b65e0df7e
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252561
    > > Reviewed-by: Aleks Totic <atotic@chromium.org>
    > > Commit-Queue: Aleks Totic <atotic@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#779872}
    > 
    > TBR=ericwilligers@chromium.org,loyso@chromium.org,atotic@chromium.org,dominickn@chromium.org
    > 
    > No-Presubmit: true
    > No-Try: true
    > No-Tree-Checks: true
    > Change-Id: I73d0c4893bd9f1f3dd397818faeaa743b0c9a97e
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252643
    > Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    > Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#779884}
    
    TBR=ericwilligers@chromium.org,loyso@chromium.org,atotic@chromium.org,dominickn@chromium.org,smcgruer@chromium.org
    
    Change-Id: If326b224e12ce775e841105646cb33891ac4fff3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252934Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#780025}
    1c38d210
BUILD.gn 9.46 KB