GitLab

Apps that are hidden in the launcher, but still able to be launched
should be able to be shown in the shelf. One example of this is the
four Android apps explicitly hidden from the launcher: Android
Settings, Android Files, Android Contacts, and Android Clock. If the
user manages to launch one of these (e.g. through Chrome OS
settings or via Play Store), they should be pinnable on the Shelf.
Currently, this doesn't work as the ARC publisher prevents apps which
are hidden from the launcher from being shown in the shelf. Practically,
this manifests as an inability to persist the pin state for these four
apps. That is, the apps can be pinned, but logging out and logging back
in loses the pin state.

This CL addresses the bug by always allowing ARC apps to be shown in the
shelf, independent of whether they are present in the launcher. This
should only affect the four apps listed as they were the only four
Android apps where the show_in_shelf value was false. A test is added to
verify the behaviour - the test fails before this CL.

BUG=1124865

Change-Id: Ie4ac89a929396e7ee4a40efd9386d4af00b532db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623610
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842865}