• Nico Weber's avatar
    win: Make chrome/installer/util/prebuild/create_string_rc write a depfile. · 1c59d48c
    Nico Weber authored
    create_string_rc.py globs a bunch of xtb files off disk behind gn's and
    ninja's back, so that they didn't know that create_string_rc.py needs to
    rerun when the xtb files are updated. Make the script write a depfile so
    that ninja knows to re-run the script if an xtb file is udpated.
    
    (This is incomplete: if an xtb file is added or removed and nothing else
    changes, the step still won't re-run. The Right Fix is to list all the xtb
    files in the gn file and pass them to the script, then make the script assert
    that the glob matches the passed-in line. That way, if an xtb is added or
    removed, the command-line tracking will make sure that the command re-runs.
    But xtb files being added or removed is super rare, so let's punt on this for
    now.)
    
    Bug: 910465
    Change-Id: I7050dee3c62d997b750d8b150504a04d086518b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1359087Reviewed-by: default avatarRobert Shield <robertshield@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#613222}
    1c59d48c
BUILD.gn 10.1 KB